Fixed: ChineseLinter.vim should not be loaded for all file types. #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…letypes, such as markdown, text.
wsdjeg
reviewed
Jan 31, 2019
| @@ -10,8 +10,8 @@ | |||
| function! SpaceVim#layers#chinese#plugins() abort | |||
| let plugins = [ | |||
| \ ['yianwillis/vimcdoc' , {'merged' : 0}], | |||
| \ ['ianva/vim-youdao-translater' , {'on_cmd' : ['Ydv' , 'Ydc', 'Yde']}], | |||
| \ ['wsdjeg/ChineseLinter.vim' , {'merged' : 0, 'on_cmd' : ['CheckChinese']}], | |||
| \ ['ianva/vim-youdao-translater' , {'merged' : 0, 'on_cmd' : ['Ydv' , 'Ydc', 'Yde']}], | |||
There was a problem hiding this comment.
lazy loaded plugin is unmerged by default, that means, if you use on_cmd, no need to add merged key.
| \ ['ianva/vim-youdao-translater' , {'on_cmd' : ['Ydv' , 'Ydc', 'Yde']}], | ||
| \ ['wsdjeg/ChineseLinter.vim' , {'merged' : 0, 'on_cmd' : ['CheckChinese']}], | ||
| \ ['ianva/vim-youdao-translater' , {'merged' : 0, 'on_cmd' : ['Ydv' , 'Ydc', 'Yde']}], | ||
| \ ['wsdjeg/ChineseLinter.vim' , {'merged' : 0, 'on_cmd' : 'CheckChinese', 'on_ft' : ['markdown', 'text']}], |
There was a problem hiding this comment.
This plugin is not runtime plugin, It is a command plugin, so no need to use on_ft feature, just use on_cmd is ok.
There was a problem hiding this comment.
Is it OK that Checkchinese command key binding appears in all file type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Prelude
Thank you for working on SpaceVim! :)
Please complete these steps and check these boxes before filing your PR:
Why this change is necessary and useful?
ChineseLinter.vim should only be load for a limit number of filetypes, such as markdown, text."