Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Javascript error occurred in the main process #2

Closed
Botspot opened this issue Oct 27, 2020 · 4 comments
Closed

A Javascript error occurred in the main process #2

Botspot opened this issue Oct 27, 2020 · 4 comments
Labels
type:feat New feature or request

Comments

@Botspot
Copy link
Contributor

Botspot commented Oct 27, 2020

I just installed your pre-packaged verion of this electron-discord-webapp, and upon launching, it displays an error:
2020-10-27-132835_1920x1080_scrot
Discord works fine within the window, however I noticed the system tray icon is missing.

@SpacingBat3
Copy link
Owner

SpacingBat3 commented Oct 27, 2020

Seems like I forget to send proper icons, I'll update archives then...
electron builder has weird behavior with the external assets like icons...
don't know how to fix that than manually pasting the icons after building the app...

EDIT: Not really... All assets are on its place. (Just information for people browsing this issue)

@Botspot
Copy link
Contributor Author

Botspot commented Oct 27, 2020

Problem was solved by first cd'ing the electron-discord-webapp folder.

With the correct folder being the present working directory, Discord launched fine, with the correct window icon and system tray shortcut.

@Botspot Botspot closed this as completed Oct 27, 2020
@SpacingBat3
Copy link
Owner

SpacingBat3 commented Oct 27, 2020

Flagging as invalid then, because it were meant to behave like this right now...

Maybe I'll change that in the next versions...

@SpacingBat3 SpacingBat3 added status:invalid This doesn't seem right type:feat New feature or request good first issue Good for newcomers and removed status:invalid This doesn't seem right labels Oct 27, 2020
@SpacingBat3 SpacingBat3 self-assigned this Oct 29, 2020
@SpacingBat3
Copy link
Owner

Actually going to "fix" that behavior because many people seem to not know how to run the app + electron has in it's API a "method" for getting the current app dir:
https://www.electronjs.org/docs/api/app#appgetapppath

@SpacingBat3 SpacingBat3 reopened this Oct 29, 2020
@SpacingBat3 SpacingBat3 removed the good first issue Good for newcomers label Oct 29, 2020
SpacingBat3 added a commit that referenced this issue Oct 29, 2020
@SpacingBat3 SpacingBat3 removed their assignment Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feat New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants