Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SA-1536] Dont send STUN binding req with turn #1

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

NicoleHippolite
Copy link

From what I can tell, the turn server stops being contactable after 10mins which causes these STUN BINDING requests to fail and causes the ICE state to be set to disconnected. I have tested this locally by just not sending these BINDING requests when using the TURN client instead of the STUN client and was live for an hour before the bumper rolled - which indicates that they're not necessary. This will only affect TURN PC's and has no impact on STUN PC's

NOTE: all I've done to the below code is add the if (pair?.protocol?.type !== "turn") { condition around what's already there

Given this is not actually a fix for whatever is causing the turn server to become uncontactable - I am not requesting this code gets merged into the shinyoshiaki repo

@NicoleHippolite
Copy link
Author

I have a Jira task SA-1617 that tracks the investigation into the actual turn server issue so we dont remain on the forked version of werift

@oeed oeed merged commit f9defbd into develop Jan 11, 2023
@oeed oeed deleted the dont-send-stun-binding-requests-with-turn branch January 11, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants