Skip to content

Commit

Permalink
Merge pull request #14 in FFE/ffe-details-list from width to master
Browse files Browse the repository at this point in the history
* commit '706a0462fc129e637da38a8baea1a7004e3b3d7a':
  Set the width of the first column to 33.33%
  • Loading branch information
wkillerud committed Jan 18, 2017
2 parents 6f97534 + c932b38 commit 20fd4a0
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 1 deletion.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# CHANGELOG

## Version 7.0.0

**Potentially breaking change:** The first column is now fixed at 33.33% width.

This change was made so long titles in the column would wrap instead of creeping
in on the space of the next column. If this - for some reason - is your desired
behaviour you need to override the `max-width` attribute to `100%`.

## Version 6.0.1
* meta-data til styleguide

Expand Down
4 changes: 4 additions & 0 deletions less/ffe-details-list.less
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,10 @@

&__details-col {
&:nth-child(1) {
// This approach was used, rather than just width: 33.33%;, because of weird behavior
// with four columns where the first column would only wrap its children, not take up
// its designated width.
max-width: 33.33%;
min-width: 33.33%;
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ffe-details-list",
"version": "6.0.1",
"version": "7.0.0",
"description": "Opplisting av attributter i en grid",
"main": "index.js",
"scripts": {
Expand Down

0 comments on commit 20fd4a0

Please sign in to comment.