Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffe-form: Add vertical padding to ffe-textarea #45

Merged
merged 3 commits into from
Mar 2, 2018

Conversation

wkillerud
Copy link
Contributor

Fixes #38

This PR adds 13px padding to ffe-textarea so text no longer hugs the top and bottom borders. It also adds a more realistic look to TextArea in the example by adding some rows.

Before and after pics:

screen shot 2018-03-01 at 20 00 15

screen shot 2018-03-01 at 19 59 54

A TextArea usually spans more than one row, so have the example reflect
that. Add some default content for good measure. This makes it easy to
spot the issue described in #38.
Fixes #38

This commit adds 13px padding to `ffe-textarea` so text no longer hugs
the top and bottom borders.
@wkillerud wkillerud added the 🐛 bug Bugs, errors and stuff that's just plain wrong label Mar 1, 2018
Copy link
Contributor

@selbekk selbekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@wkillerud wkillerud merged commit e61af11 into master Mar 2, 2018
@wkillerud wkillerud deleted the 38-textarea-padding branch March 2, 2018 15:23
kwltrs pushed a commit that referenced this pull request Mar 7, 2018
ffe-form: Add vertical padding to ffe-textarea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Bugs, errors and stuff that's just plain wrong
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants