Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Finder (External Site) - Map drop pin showing View Group button when linked detail page is blank #1735

Closed
3 of 4 tasks
BEGamache opened this issue Sep 2, 2016 · 2 comments
Labels
Priority: High Affects most production Rock installs in a way that will be noticed. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Lava Related to the Lava templating language. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@BEGamache
Copy link

BEGamache commented Sep 2, 2016

Prerequisites

Description

In Group Finder on the External site when the block has an empty Linked Group Details page attribute/field the View Group button is visible when you click on a drop pin even though the lava used is suppose to check and make sure only to show that button when Group Details linked page isn't empty.

Steps to Reproduce

http://rock.rocksolidchurchdemo.com/page/236
Hit search.
Click on a drop pin. View Group button visible.
Edit block settings. Linked pages tab should have Group Details Linked Page empty.
Lava for the map should have a condition to only show that button when a details page is linked.

Expected behavior: [What you expected to happen]
No View Group button if no linked detail page

Actual behavior: [What actually happened]
View Group button visible.

Versions

  • Rock Version: v5.2
@BEGamache BEGamache changed the title Group Finder (External Site) - Map drop pin showing View Group button when linked page is blank Group Finder (External Site) - Map drop pin showing View Group button when linked detail page is blank Sep 2, 2016
@arranf arranf added Type: Bug Confirmed bugs or reports that are very likely to be bugs. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. labels Oct 12, 2016
@garrettjohnson garrettjohnson added the Topic: Lava Related to the Lava templating language. label Sep 9, 2017
@garrettjohnson
Copy link
Contributor

Related to #2172, will need the migration mentioned on PR #2449 to close

@arranf arranf added the Priority: High Affects most production Rock installs in a way that will be noticed. label Sep 9, 2017
@arranf
Copy link
Contributor

arranf commented Jun 13, 2018

Fixed.

@arranf arranf closed this as completed Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Affects most production Rock installs in a way that will be noticed. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Topic: Lava Related to the Lava templating language. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

3 participants