Added option to select group to only show descendant groups in GroupListPersonalizedLava #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need to display the information for only certain ministries' small groups. By selecting a group ancestor we can now show a leader their high school groups, and not their in-home small group.
Goal
It will allow this block to become more targeted.
Strategy
If the parent group is set, the block will recursively look up the IDs of all ancestors of that group. It then adds the where to the query. This may be slow if it is working through a huge number of groups, so I added caching of the IDs. The default cache length is 1 hour but it is configurable.
Possible Implications
This should not affect backward compatibility as any block that does not have a parent group set will continue as normal. Selecting a group with a great number of ancestors may be slow.