Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Registration URL Slug field doesn't allow uppercase letters #4940

Closed
1 task done
leahjennings opened this issue Mar 14, 2022 · 2 comments
Closed
1 task done
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Enhancement Feature requests. x-Fixed in v13.4
Milestone

Comments

@leahjennings
Copy link
Collaborator

leahjennings commented Mar 14, 2022

Prerequisites

A Picture Is worth a Thousand Words

image

Description

When adding a URL Slug to an event registration instance, the validation on the field doesn't allow uppercase letters. I believe all that would be needed to fix this is to adjust the regular expression in the following two files to include uppercase letters. This occurs in both the Event Registration Wizard block and the Registration Instance Linkage Detail block. The validation error message implies that there are special characters present, but it is actually failing on the uppercase letter.

Changing from ValidationExpression="^[a-z0-9]+(?:-[a-z0-9]+)*$" /> to ValidationExpression="^[a-zA-Z0-9]+(?:-[a-zA-Z0-9]+)*$" /> would allow uppercase letters.

ValidationExpression="^[a-z0-9]+(?:-[a-z0-9]+)*$" />

ValidationExpression="^[a-z0-9]+(?:-[a-z0-9]+)*$" />

Steps to Reproduce

  1. On the demo site, go to Tools > Event Wizard
  2. Select "Baptism" as the Registration Template, then click Next
  3. In the Slug field, type a word with an uppercase letter in it
  4. Notice how the validation error implies there is a special character present, but validation is actually failing on the uppercase letter
    image

Expected behavior:

The Url Slug field would accept the slug with uppercase letters in it.

Actual behavior:

An entered Url Slug with an uppercase letter and no special characters fails validation.

Versions

  • Rock Version: [Rock McKinley 13.0 (1.13.0.30)]
  • Client Culture Setting: [en-US]
@crayzd92
Copy link
Contributor

Hi @leahjennings, the intent here is that the slugs are only lowercase. We are going to work on changing that validation message to more clearly indicate our intent.

@crayzd92
Copy link
Contributor

Fixed by updating the validation message to indicate intent
image

@crayzd92 crayzd92 added this to the v13 milestone Mar 14, 2022
@crayzd92 crayzd92 added Type: Enhancement Feature requests. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. labels Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Enhancement Feature requests. x-Fixed in v13.4
Projects
None yet
Development

No branches or pull requests

2 participants