New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MediaPlayer Lava Short Code Download Enabled with MP3 File But Download Link is Empty #5426
Comments
@frogydiak This appears to be fixed. I would guess it was part of #5445, since that updated the Plyr library version it was most likely an issue in the library. I tested on 15.3 and pre-alpha and both include the link correctly. I also verified that clicking on the button does actually work. I'm going to mark this as fixed in 15.3, but if you have 15.1 it is probably fixed there too. <div style="max-width: 400px;">
{[ mediaplayer src:'https://file-examples.com/storage/feaade38c1651bd01984236/2017/11/file_example_MP3_700KB.mp3' type:'audio' controls:'play,progress,mute,volume,download' ]}{[ endmediaplayer ]}
</div> |
@cabal95 , I'm using the Audio File attribute to contain the MP3 file and it gets uploaded to S3, so, in my lava I'm using:
I just tested it again and the link to the file is still missing. Seems like you are using the default way messages was setup and is using a text attribute and a direct link to the mp3 file wherever it was hosted. That way is too technical for our staff. Thanks for looking at this. |
@frogydiak Can you provide the actual URL that you are passing to the mediaplayer shortcode so we can replicate exactly what you are doing when the shortcode executes? |
@frogydiak Okay I think I was able to reproduce it. It only happens in Chrome. It seems to work fine in Firefox. Just to make sure I'm hunting down the same cause of the problem you are having, can you try in Firefox and see if the download URLs work correctly? |
@cabal95 Yes, you are right, it is working properly in FireFox (Mac). I also tested it with Microsoft Edge (latest version for Mac) same thing as Chrome no file link. It is working properly with Safari though. |
Thanks for confirming @frogydiak. I have a fix that I will finish up Monday after some additional testing. |
Please go through all the tasks below
The download button is showing up but clicking on it will download the page HTML instead of the MP3 file and looking at the button link, you'll notice that the href is empty.
Expected Behavior
Clicking on the download button should download whatever is in the src I supposed:
Actual Behavior
Clicking on the download button will download the page HTML file instead.
Steps to Reproduce
Use the MediaPlayer Lava short code like this:
Manually set the controls with download.
Rock Version
14.2## Client Culture Setting
en-US
The text was updated successfully, but these errors were encountered: