Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Attendance Block in v15 fails to record non-attendees non-attendance #5473

Closed
1 task done
raufrecht opened this issue Jun 9, 2023 · 0 comments
Closed
1 task done
Labels
Fixed in v15.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.

Comments

@raufrecht
Copy link

raufrecht commented Jun 9, 2023

Please go through all the tasks below

  • Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

When marking attendance on the new attendance entry block, you mark those who have attended. After you are done marking attendance, if you go look at the % attended for the date you just marked attendance for on the group attendance list, it will show 100% no matter how many people you mark as attended.
image
image

In researching the issue, the new block only writes attendance records for those people you check. Previously, the system would write attendance records for all group members and use the field DidAttend to determine who was in attendance and who was not.
After marking attendance if you run SQL: select * from Attendance where OccurrenceId=78654 where the OccurrenceId is for the date you just entered attendance, you will see there are now only DidAttend=1 records and not records for every group member. If you go back into the Attendance Entry and remove a person, the system properly changes the person to DidAttend=0 and the percentage drops below 100%. The only way to get an accurate percentage currently is to mark everyone as present, then unmark those who didn't attend.

Expected Behavior

The percent Attended should reflect the percentage of those who attended against the number of group members in the group at the time of the meeting. In my example above, I have 3 group members, therefore the percentage should be 33%.

Actual Behavior

The percent attended is being calculated based on how many records are selected divied by the maximum number of records that had been selected since the creation of the attendance entry. If you go back and uncheck a person, or add more people then remove them, the attendance Percent will change.

Steps to Reproduce

  • Go to 'Group Viewer'
  • Click on 'Decker Group' under 'Section A'
  • Click on Attendance
  • Click on the most recent attendance record
  • Click on a single person in the group to mark them attended
  • Click on Back
  • See that the Percent Attended = 100% rather than 25%

Rock Version

15.0 (1.15.0.16)

Client Culture Setting

en-us

@sparkdevnetwork-service sparkdevnetwork-service added the Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. label Jun 12, 2023
@joshuahenninger joshuahenninger added the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Jun 14, 2023
@joshuahenninger joshuahenninger added Fixed in v15.1 and removed Status: In Dev Queue This issue is being worked on, and has someone assigned. labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v15.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.
Projects
None yet
Development

No branches or pull requests

3 participants