Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsidian Login block causes an "Error 400: invalid_request" when using Google Authentication #5478

Closed
1 task
leahjennings opened this issue Jun 14, 2023 · 0 comments
Labels
Fixed in v15.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.

Comments

@leahjennings
Copy link
Collaborator

leahjennings commented Jun 14, 2023

Please go through all the tasks below

  • Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

When Google Authentication is used with the new Obsidian Login block after clicking Sign in with Google, Google's authentication service gives the following error message: "You can't sign in to this app because it doesn't comply with Google's OAuth 2.0 policy for keeping apps secure."

image

My theory is that the redirect_uri getting passed to Google is missing a / character from the path:
image

And I think that's caused by line 741 in the Login.cs file
image

We use Google authentication with the Login (Legacy) block without any problems.

Expected Behavior

I would expect that once configured, the Google authentication process would complete and successfully return back to Rock as an authenticated person.

Actual Behavior

The Google services gives a "Error 400: invalid_request" and the login process is never completed.

Steps to Reproduce

  • On a Rock server running v15.0 (this is the version I believe the Obsidian Login block was introduced), and with Google Authentication configured as an external auth type, navigate to the /Login page
  • Remove the Login (Legacy) block
  • Add the Obsidian > Security Login block
image
  • Configure the block settings to allow Google authentication as a secondary authentication type
image
  • Navigate to the login page and click on "Sign in with Google"
  • Notice the redirect to the Google error message

Rock Version

Rock McKinley 15.0 (1.15.0.16)

Client Culture Setting

en-US

@joshuahenninger joshuahenninger added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Status: In Dev Queue This issue is being worked on, and has someone assigned. labels Jun 15, 2023
@joshuahenninger joshuahenninger added Fixed in v15.1 and removed Status: In Dev Queue This issue is being worked on, and has someone assigned. labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v15.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.
Projects
None yet
Development

No branches or pull requests

2 participants