Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of Workflow Attribute type Location doesn't allow you to proceed even when it's filled in properly #5561

Closed
1 task done
leahjennings opened this issue Aug 29, 2023 · 0 comments
Labels
Fixed in v16.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@leahjennings
Copy link
Collaborator

Please go through all the tasks below

  • Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

Whenever a Location field type is added to a workflow to be filled in via a workflow form and is required, the form's validation won't let you proceed. The validation also shows that "Location is required" twice, eveen though the attribute is only present once.
image

It happens regardless of the type of location used (Named, Address, Point, or Geo-Fence). Weirdly though, if picking a Point or Geo-Fence address, the validation message only shows once. If using an Address or Named, the validation message shows twice.

I tested it in Event Registration, and while event registration will let you continue the validation message still shows:
image

Expected Behavior

I would expect that I could enter any of the configured location types to a field type of Location and that would satisfy the validation so I could proceed with the form.

Actual Behavior

If the Location field type is set to required, the validation doesn't allow you to proceed regardless of what is selected in that field.

Steps to Reproduce

  • On the demo server, go to Admin Tools > General Settings, click on Workflow Configuration
  • Click on any category and then click the + button to create a new workflow
  • Add a Workflow attribute of type Location
image
  • Add a Workflow Form action to the Start activity
  • Set the Location attribute to Visible / Editable / Required
image
  • Hit the play icon to launch the workflow
  • Fill in the location attribute using any of the given options
image
  • Notice that regardless of what is chosen, the validation doesn't allow you to proceed
image

Rock Version

Rock McKinley 15.1 (1.15.1.1)

Client Culture Setting

en-US

@sparkdevnetwork-service sparkdevnetwork-service added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Status: In Dev Queue This issue is being worked on, and has someone assigned. Type: Bug Confirmed bugs or reports that are very likely to be bugs. labels Oct 17, 2023
@MrUpsideDown MrUpsideDown added Fixed in v16.1 and removed Status: In Dev Queue This issue is being worked on, and has someone assigned. labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v16.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

3 participants