Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alpha 1.16.0.10] Obsidian Family Pre-Registration redirect doesn't include PlannedVisitDate merge field #5562

Closed
1 task done
leahjennings opened this issue Aug 29, 2023 · 1 comment
Assignees
Labels
Fixed in v15.2 Fixed in v16.0 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.

Comments

@leahjennings
Copy link
Collaborator

Please go through all the tasks below

  • Check this box only after you have successfully completed both the above tasks

Please provide a brief description of the problem. Please do not forget to attach the relevant screenshots from your side.

When filling out the new Obsidian Family Pre-Registration block, the Planned Visit Date (when visible) is not passed into the redirect URL as the When page parameter:
image

image

We have not modified the default behavior. For clarity, here's the redirect URL configured on the block:
~/FamilyPreRegistrationSuccess?FamilyId={{ Family.Id }}&Parents={{ ParentIds }}&Children={{ ChildIds }}&When={{ PlannedVisitDate }}

Expected Behavior

I would expect that when the Planned Visit Date is visible, it would be passed into the resulting page as the PlannedVisitDate merge field.

Actual Behavior

The PlannedVisitDate merge field is empty, and therefore not passed into the page you are redirected to.

Steps to Reproduce

  • Go to a Rock instance running at least Alpha 1.16.0.10
  • As a logged in user, go to the page where the Obsidian Family Pre-Registration block is located
    • On most instances, it's accessible at /FamilyPreRegistration
    • The v16 upgrade will automatically replace the existing block with the Obsidian version
  • Edit the block settings to confirm that the Planned Visit Date field is Required and the Redirect Url is the following (should be default): ~/FamilyPreRegistrationSuccess?FamilyId={{ Family.Id }}&Parents={{ ParentIds }}&Children={{ ChildIds }}&When={{ PlannedVisitDate }}
image image
  • Refresh the page and fill in the required fields
    image

  • Click Save and notice that the "We're excited to see you on...!" is missing the date. You can also look at the URL and notice that it is missing from the page parameters

Rock Version

Rock McKinley 16.0 (1.16.0.10), Rock McKinley 17.0 (1.17.0.1)

Client Culture Setting

en-US

@joshuahenninger joshuahenninger added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Status: In Dev Queue This issue is being worked on, and has someone assigned. Fixed in v16.0 Fixed in v15.2 and removed Status: In Dev Queue This issue is being worked on, and has someone assigned. labels Sep 7, 2023
@joshuahenninger
Copy link
Contributor

@leahjennings, This issue has been fixed in commit f1127ffa. It will be included in v1.15.2 and v.1.16.0, and will be in the next 1.17.0.2 Pre-Alpha release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v15.2 Fixed in v16.0 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.
Projects
None yet
Development

No branches or pull requests

2 participants