Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign-Ups Does not Hide the Search and Clear Filter Actions When all of the filters are turned off #5621

Closed
2 tasks done
frogydiak opened this issue Oct 4, 2023 · 1 comment
Labels
Fixed in v15.2 Fixed in v16.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.

Comments

@frogydiak
Copy link

Description

The search and clear filter actions are still visible although all of the filters are not enabled.

image

Actual Behavior

See screenshot above

Expected Behavior

The search and clear buttons should disappear when there is nothing to filter.

Steps to Reproduce

Uncheck all available filters for Sign-Ups, do this by going to the sign-up page in the external website Block Configuration since there is a bug in the internal site. The setting for the Sign-Up Finder block does not show the Settings.

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

15.1

Client Culture Setting

en-US

@jasonhendee jasonhendee added the Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. label Oct 4, 2023
@jasonhendee
Copy link
Contributor

@frogydiak This should be resolved as of Rock v15.2. Thanks for reporting it! Also, note that you can change the Results Header Lava Template to a more appropriate message in this case, since the individual will no longer be performing a search.

GitHub Issue 5621 - Results Header Lava Template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v15.2 Fixed in v16.1 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.
Projects
None yet
Development

No branches or pull requests

2 participants