Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript Error on Connection Opportunity Item with Apostrophe in the Title #5625

Closed
2 tasks done
frogydiak opened this issue Oct 5, 2023 · 5 comments
Closed
2 tasks done

Comments

@frogydiak
Copy link

frogydiak commented Oct 5, 2023

Description

Open Developer Tools in your browser and go to Console:

image

Clicking the link in he right of the error and you'll see:

image

I don't know if the javascript error affect anything but it is still functional.

Actual Behavior

See description

Expected Behavior

Shouldn't hany any console error.

Steps to Reproduce

I'm working on Serving Opportunities and created an entry and titled "Children**'s** Ministries Volunteer".

  • Go to the entry and open it
  • Click on 'a request'
  • Open your developer tools > console and you'll see an error

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

15.1

Client Culture Setting

en-US

@nairdo
Copy link
Member

nairdo commented Oct 5, 2023

@frogydiak I've tried reproducing this without success. Am I missing something?

devenv_duTjIbuUNi.mp4

@Jon-Corey
Copy link
Contributor

This looks like a duplicate of #5595.

@nairdo, this issue is only caused by the single quote character ('), not by other similar-looking characters such as the apostrophe/smart quote (). I can't tell from your video which character you are using, but that may explain why you can't reproduce this.

@frogydiak
Copy link
Author

@nairdo I just tested it in Rock Demo and there's an error:

Video capture: https://take.ms/0wMaf

@nairdo
Copy link
Member

nairdo commented Oct 6, 2023

@nairdo, this issue is only caused by the single quote character ('), not by other similar-looking characters such as the apostrophe/smart quote...

I was just using the simple single quote also. It might be that the issue still exists in the filter we wrote for Fluid but was fixed in the DotLiquid version. I've put this into the developer pipeline to confirm/fix.

[Update: The issue only surfaces when using the Fluid Lava engine, but that issue is resolved in 5595.]

@sparkdevnetwork-service sparkdevnetwork-service added the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Oct 6, 2023
@MrUpsideDown
Copy link
Collaborator

Confirmed and closed as duplicate of #5595.

@MrUpsideDown MrUpsideDown added Fixed in v16.1 and removed Status: In Dev Queue This issue is being worked on, and has someone assigned. labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants