Sign-Ups feature displays inactive schedules when using named schedule filters

[KarenRossi84]

Description

When utilizing the named schedule filter on the Sign-Up Finder block all schedules are displaying under the root selected, including INACTIVE schedules. I should be only given the option of selecting ACTIVE schedules.

Actual Behavior

All schedules display including inactive ones.

Expected Behavior

I would expect that only the active schedules would display as filter options.

Steps to Reproduce

• Create a page with the sign-up finder block
• Edit the block settings to enable Display Name Schedule Filter
• Select a Root Schedule Category that has both active and inactive schedules
• See all schedules display on the filter including the inactive ones

Issue Confirmation

• Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

1.15.1.1 and [BETA]1.16.0.12

Client Culture Setting

en-us

[chead4]

@KarenRossi84 Hi Karen - Thank you for the submission. We are closing this issue as sign up opportunities with an inactive schedule do not display in the returned results when searching. Please feel free to submit an idea for inactive schedules to not appear in the filter by submitting an idea on the Rock Community Ideas board via http://community.rockrms.com/ideas.

[JimMichael]

Can we get a little more explanation of the logic of not considering this a bug? Under what circumstances is it considered "right" to allow someone to filter on something that cannot possibly return results (as is the case with showing Inactive Schedules, but results from said Schedules are never returned)

I totally get the desire to use the "this is working as designed" argument as often as possible, but sometimes the design is just... wrong.

[chead4]

@JimMichael Hi Jim Thank you for the feedback. After taking another look at the issue we agree that inactive schedules should not display in the filtered list on Sign Up Finder page. We will move forward and fix this issue.