Obsidian Registration Fee options hidden if a "Max Available" is not set and "Hide When None Remaining" is checked

[leahjennings]

Description

We often have Registration Templates setup to where there is a Fee (set to Multiple) that has options with max available quantities and some that don't have a maximum. The ones that don't have a maximum, we just leave the Max Available blank for that option (see screenshot for example).

With the new Obsidian Registration block, if the "Hide When None Remaining" is checked, then any option that doesn't have a max available set is assumed to be "none left" and is hidden.

If Hide When None Remaining is not checked, then the fees without a Max Available set show up as expected and are able to be selected.

I saw bug #5408, but I believe this is different (albeit possibly related).

Ignore the purple in the screenshots, I promise I was on the demo site - someone else just must've been in there testing, too. 😄

Actual Behavior

When there is a fee [Options = Multiple] configured on a template, any option that doesn't have a Max Available set will be hidden if Hide When None Remaining is checked. Rock is assuming that an empty Max Available value should be 0 in that specific circumstance.

Expected Behavior

I would expect that Rock would assume that an empty Max Available value means there is no maximum.

Steps to Reproduce

• On the demo site, navigate to Tools > Event Registration
• Expand the General template category and click on Summer Camp
• Edit the template, click to expand Fees, and then click the pencil for the Camp Shirt fee

• Check the box for Hide When None Remaining
• Add quantities to two of the sizes' Max Available, then click Save

• Save the template
• Click the + button to add a new instance of the template Summer Camp
• Name it whatever you'd like, then click to Save

• Click on the Linkages tab and create a new linkage

• Navigate to Admin Tools > CMS Configuration, then click on Pages
• Expand External Website > Calendar, then click on Registration
• Remove the legacy "Registration Entry" block and add the new Obsidian Registration Entry block

• In a new tab, navigate to http://rock.rocksolidchurchdemo.com/registration/testingobsidianfees
  • Be sure to adjust the URL based on the Rock instance you're testing on and the slug you created in an earlier step
• Notice how the two options that don't have a Max Available set are hidden

Issue Confirmation

• Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

Rock McKinley 15.1 (1.15.1.1), 16.0 (1.16.0.12)

Client Culture Setting

en-US

[cabal95]

Hey @leahjennings, thanks for the detailed screenshots and reproduction steps. This got fixed today as part of commit d952a13. We found a number of issues internally related to some edge cases with how the new Obsidian Registration Entry block handles fees in commit.

I ran your test against the updated code and I believe it has also fixed the issue you saw.