Passwordless SMS - Incorrect Error Message

[tikool17]

Description

Not a major issue, but when using a phone number for passwordless login, if you enter a number that does not accept text messages it throws an error about a system communication:

"Passwordless Login Confirmation System Communication is not configured for SMS"

We ran into this when someone was trying to log in with their landline home phone number. The person was unable to realize they couldn't login because they weren't using a mobile phone because the error message isn't related to actual the error. I have tested this with other landline numbers on our site as well as another church's site in production. (Also, the system communication the error is referring to is set up correctly and is configured for SMS.)

Actual Behavior

Error message "Passwordless Login Confirmation System Communication is not configured for SMS" is thrown

Expected Behavior

It would be nice to have a message something like "Unable to send confirmation code. Make sure to use a mobile phone that can receive text messages."

But at least it should throw a generic error suggesting the user try something else and not one that looks like there's a config error on the website.

Steps to Reproduce

• Log in on a production instance with an active SMS transport. (we use Twilio)
• Enter in a 10 digit phone number that doesn't accept text messages. (e.g. landlines, 555-555-5555)
• See error message

Issue Confirmation

• Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

16

Client Culture Setting

en-US

[joshuahenninger]

@tikool17 Thank you for bringing this issue to our attention. It has been resolved in commit e8366fb5 and will be included in v16.1.

We agree that the generic error message you provided is better suited to help individuals fix the issue. Please note that the SMS communication transport errors are visible in System Settings > Exception List.