Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FinancialBatchDetail block shows no loading/saving indicators #5661

Closed
2 tasks done
OnlyByGrace opened this issue Nov 1, 2023 · 0 comments
Closed
2 tasks done

FinancialBatchDetail block shows no loading/saving indicators #5661

OnlyByGrace opened this issue Nov 1, 2023 · 0 comments
Labels
Fixed in v16.4 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@OnlyByGrace
Copy link
Contributor

Description

When editing or saving a batch with the new Obsidian FinancialBatchDetail block, no loading indicators are shown while the block is loading or saving the batch. This is particularly obvious when saving the batch, because the Save button is not disabled, either. So there is an awkward 3-4 second pause (depending on internet connection, presumably) where absolutely nothing happens on the page after you click save. The natural instinct is to click Save repeatedly until something happens.

Actual Behavior

When you click edit or save, there is an awkward pause where the user is unsure of what is happening on the page.

676c711c-7693-40e3-a017-72d803a53457

Expected Behavior

I would expect the loading/saving behavior to be consistent with other parts of Rock where the blue loading indicator shows in an overlay on top of the page.

Steps to Reproduce

  • Go to the Batches page and click on any batch
  • Open your web inspector and choose "Slow 3G" on the Network tab to simulate poor network conditions
  • Click edit on the batch
  • Make a change and click save on the batch
  • Observe (especially when saving) the unresponsiveness of the page

image

518973bf-3189-4478-a39c-f95b417f6029

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

Rock McKinley 17.0 (1.17.0.5) (demo site)

Client Culture Setting

en-US

@OnlyByGrace OnlyByGrace changed the title FinancialBatchDetail block shows no loading indicators FinancialBatchDetail block shows no loading/saving indicators Nov 1, 2023
@sparkdevnetwork-service sparkdevnetwork-service added the Type: Bug Confirmed bugs or reports that are very likely to be bugs. label Nov 1, 2023
@sparkdevnetwork-service sparkdevnetwork-service added Status: In Dev Queue This issue is being worked on, and has someone assigned. Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. labels Nov 9, 2023
@PraveenMathew92 PraveenMathew92 added Fixed in v16.4 and removed Status: In Dev Queue This issue is being worked on, and has someone assigned. labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v16.4 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

3 participants