Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Detail page is missing from BreadCrumbs with new BatchDetail Obsidian block #5664

Closed
2 tasks done
OnlyByGrace opened this issue Nov 2, 2023 · 2 comments
Closed
2 tasks done

Comments

@OnlyByGrace
Copy link
Contributor

Description

When clicking through from the Batch Detail page to a sub page such as the Audit Log, Transaction Matching, or Transaction Detail page, the Batch Detail page is missing from the breadcrumbs.

image

image

Actual Behavior

When clicking through from the Batch Detail page to a sub page such as the Audit Log, Transaction Matching, or Transaction Detail page, the Batch Detail page is missing from the breadcrumbs.

Expected Behavior

The Batch Detail Page (with the name of the batch) is displayed in the breadcrumbs as it is in v15.

Steps to Reproduce

  • Go to the Batches page and click on a batch
  • Click on a transaction in the batch to view the details of the transaction
  • Observe the breadcrumbs missing the Batch Detail page

d52798e8-10b3-4162-8c74-e974c007e0b9

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

Rock McKinley 17.0 (1.17.0.5) (from demo site)

Client Culture Setting

en-US

@OnlyByGrace
Copy link
Contributor Author

IMO this is a relatively minor issue, but I raise it because it appears to be something that will be an issue as more Obsidian blocks are pushed. Our finance team noticed this immediately because it changed their workflow. I suspect other teams would notice with other blocks, as well.

@jonedmiston
Copy link
Member

@OnlyByGrace The team just completed a major re-work of how breadcrumbs work in Rock to allow for Obsidian to use breadcrumbs and to fix some issues that have been in the original implementation since the beginning. We're on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants