Giving Overview Error: The cast to value type 'System.Decimal' failed because the materialized value is null.

[mkinyon]

Description

The Giving Overview block will cause an exception under certain giving conditions. This can happen if the Giving Automation settings are configured to have a custom list of financial accounts that are a mix of tax deductible and non tax deductible. Also, the person record that is viewed has a transaction with a single non tax deductible gift (transaction detail). See the details below on how to recreate this error.

I believe the error can be fixed by changing line 338 from this:

Rock/RockWeb/Blocks/Crm/PersonDetail/GivingOverview.ascx.cs

Line 338 in 167089c

TotalAmountBeforeRefund = a.TransactionDetails.Where(td => td.Account.IsTaxDeductible == true).Sum( d => d.Amount ),

to:
TotalAmountBeforeRefund = a.TransactionDetails.Where(td => td.Account.IsTaxDeductible == true).Sum( d => ( decimal? ) d.Amount ) ?? 0.0M,

Actual Behavior

The block will throw the following exception.

Expected Behavior

To not throw an exception.

Steps to Reproduce

• Go to Finance > Giving Alerts > Giving Automation Configuration.

• Change the Accounts option to Custom and choose at least one account that is tax deductible and one account that is not tax deductible. (In this example, the Building Fund is NOT tax deductible.)
  

• Next, setup a person record with some transactions. Have some of the transactions have gifts made to the tax deductible account. Others to the non tax deductible account. (NOTE: To trigger the error, it's important that both types of gifts are not in the same transaction (multiple transaction details. There should be at least one stand alone transaction with a single non tax deductible gift.
  

• Go to the person record and then go to the contributions tab. The error should appear.

Issue Confirmation

• Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

v15+

Client Culture Setting

en-US