Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giving Alerts do not set Workflow Attributes as stated in documentation #5685

Closed
2 tasks done
azturner opened this issue Nov 29, 2023 · 1 comment
Closed
2 tasks done

Comments

@azturner
Copy link
Contributor

Description

When a giving alert is configured to launch a workflow, the documentation and help text indicate that the person will be set as the initiator of the workflow and a FinancialTransactionId attribute will be set if it exists.

image

image

Neither of these values are being set. Code shows instead, that a Person attribute is trying to be set, however, it's using Person alias instead of PersonAlias guid, and the initiator is not being set when workflow is launched:

image

Actual Behavior

Neither the initiator or a FinancialTransactionId attribute value are being set when workflow is launched from giving alert like documentation and help text mention.

Expected Behavior

The initiator is correctly set to the person, or a Person attribute is set correctly and a FinancialTransactionId attribute is set correctly.

Steps to Reproduce

Configure a workflow and add serveral TEXT attributes with following keys:
Person
FinancialTransactionId
FinancialTransactionAlert
FinancialTransactionAlertType

Configure a giving alert to launch this workflow.
Make sure there are people that would meet criteria of the giving alert.
Run the Giving Automation job

Evaluate the workflows that were launched by the job.

Person will contain a person guid (and not a personalias guid), FinancialTransactionId will be blank, and the FinancialTransactionAlert and FinancialTransactionAlertType attributes will contain a guid. Also the initiator will be blank.

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

v14.3 (and code has not change in dev branch yet)

Client Culture Setting

en-US

@sparkdevnetwork-service sparkdevnetwork-service added the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Nov 29, 2023
@PraveenMathew92 PraveenMathew92 added Fixed in v15.4 and removed Status: In Dev Queue This issue is being worked on, and has someone assigned. labels Dec 27, 2023
@PraveenMathew92
Copy link
Contributor

PraveenMathew92 commented Dec 27, 2023

Fixed in 060c14e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants