Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registration Entity Command Not Returning DiscountCode Property #5707

Closed
2 tasks done
stevekleinliquid opened this issue Jan 7, 2024 · 1 comment
Closed
2 tasks done
Labels
Fixed in v15.4 Fixed in v16.3 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Enhancement Feature requests.

Comments

@stevekleinliquid
Copy link

Description

Here's the data:

Screen Shot 2024-01-06 at 12 11 37 PM

Here's some Lava which should display stuff:

{% registration id:'{{ registrationId }}' securityenabled:'false' %}
    {% for r in registrationItems %}
        {% assign discountCode = r.DiscountCode %} Discount code is {{ discountCode }}<br />
        {% assign discountPercentage = r.DiscountPercentage %} Discount percentage is {{ discountPercentage }}<br />
        {% assign discountAmount = r.DiscountAmount %} Discount amount is {{ discountAmount }}<br /><br />
    {% endfor %}
{% endregistration %}

Here's what gets displayed:

Discount code is
Discount percentage is 0.00
Discount amount is 349.00

Actual Behavior

The Registration entity command does not return the DiscountCode property.

Expected Behavior

The Registration entity command should return the DiscountCode property.

Steps to Reproduce

  • Create a Registration Template with a discount code
  • Create a Registration Instance
  • Register using the discount code
  • Confirm that the Registration.DiscountCode property is updated in the DB
  • Confirm that the Registration.DiscountCode property cannot be retrieved using a Lava entity command

I did this on the demo site:

Screen Shot 2024-01-07 at 2 37 03 PM Screen Shot 2024-01-07 at 2 39 31 PM

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

15.2

Client Culture Setting

en-US

@chead4
Copy link

chead4 commented Jan 12, 2024

@stevekleinliquid Hi Steve - thanks for bringing this to our attention. After taking a look, it seems that Discount Code isn't currently supported in Lava. But thanks to you, we are working on adding Discount Code and it will be available soon.
chrome_jfaGsauCjJ

@sparkdevnetwork-service sparkdevnetwork-service added the Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v15.4 Fixed in v16.3 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Enhancement Feature requests.
Projects
None yet
Development

No branches or pull requests

4 participants