Contribution Statement Generator Block Not Hiding Refunds for Transactions in Differing Years

[bmurphy-dev]

Description

If a refund is issued in the next year of a prior year transaction, both the original transaction and the negative refund amount shows on the contribution statements regardless of the Contribution Template filter selection to Hide Refunded Transactions.

Actual Behavior

The prior year and next year refund transactions all show on the contribution statements even with the Contribution Template filter selection to Hide Refunded Transactions set to true.

Expected Behavior

The prior year (orig) transaction shouldn't show, the new year refunded transaction shouldn't show based on the Contribution Template filter selection to Hide Refunded Transactions setting regardless of the statement year selected (or in the url param).
I think that the block needs to account for that filter setting on the template as well as the original transaction having a refund, regardless of when the refund occurs (new year).

Steps to Reproduce

1. Go to Finance - Financial Settings - Contribution Templates - Edit the Rock Default template to verify that the Filter Settings to Hide Refunded Transactions is true (checked).
2. Find a transaction from the prior year (2023) orig-tx
3. Refund it in the new year (2024) refund-tx
4. Find the owner of the transaction and view their contribution statement
5. See that the original transaction that was refunded is still listed on their statement

Here is a 3 min video of the steps and issue presented.

Issue Confirmation

• Perform a search on the Github Issues to see if your bug or enhancement is already reported.
• Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

v13.4 through v16.0

Client Culture Setting

en-US