Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Run Workflow Action Parameters Not Saving #5743

Closed
2 tasks done
briankalwat opened this issue Feb 7, 2024 · 2 comments
Closed
2 tasks done

SQL Run Workflow Action Parameters Not Saving #5743

briankalwat opened this issue Feb 7, 2024 · 2 comments
Labels
Fixed in v17.0 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@briankalwat
Copy link
Contributor

briankalwat commented Feb 7, 2024

Description

Tell us what you see!

Actual Behavior

I found a bug tonight where the Workflow Type Detail block will not save parameters on a newly added SQL Run workflow action. It saves the workflow, but anything added to the parameters is just forgotten, and then the action fails to run if the query relies on them. It does not appear to be an issue if the workflow type has been saved since the SQL Run action has been added – it's only when you try to add the action and populate parameters and save it all in one go.

Expected Behavior

SQL Run workflow action parameters should always be saved when the workflow type is saved.

Steps to Reproduce

  • Add a new SQL Run workflow action to any workflow
  • Populate at least one parameter key/value
  • Save workflow type
  • Edit workflow type
  • See that parameters on the SQL Run action were not saved

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

17.0.12

Client Culture Setting

en-US

@briankalwat briankalwat changed the title SQL Run Workflow Action Parameters Not Saved SQL Run Workflow Action Parameters Not Saving Feb 7, 2024
@sparkdevnetwork-service sparkdevnetwork-service added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs. labels Feb 7, 2024
@briankalwat
Copy link
Contributor Author

So, it turns out this is also happening with the Key/Value list Defined Value attribute for Text to Workflow. It may be a system-wide bug with Key/Value list field type.

@chead4
Copy link

chead4 commented Feb 8, 2024

@briankalwat Hi Brian - I have added the issue from your comment to our internal ticket and this will be addressed as well.

@sparkdevnetwork-service sparkdevnetwork-service added the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Feb 23, 2024
@sparkdevnetwork-service sparkdevnetwork-service removed the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Feb 27, 2024
@sparkdevnetwork-service sparkdevnetwork-service added Status: In Dev Queue This issue is being worked on, and has someone assigned. and removed Status: In Dev Queue This issue is being worked on, and has someone assigned. labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v17.0 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

3 participants