Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rock Media Short Code Thumbnail Bug #5753

Closed
2 tasks done
Jchinlcbc opened this issue Feb 14, 2024 · 1 comment
Closed
2 tasks done

Rock Media Short Code Thumbnail Bug #5753

Jchinlcbc opened this issue Feb 14, 2024 · 1 comment
Labels
Fixed in v16.4 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@Jchinlcbc
Copy link

Description

Device: Mac OS Safari, IOS any Browser
It appears that the media player doesn't show the thumbnail poster, but instead shows the first frame of the video.

MacOS Sonoma 14.3.1

Screenshot 2024-02-14 at 9 37 03 AM

Iphone 13 IOS 17.2.1

IMG_0954

To fix this issue, add .plyr__video-wrapper{ overflow:initial; } to the styling of your page

This bug doesn't appear on an android 1Plus 3 running OxygenOs 9.0.6 as seen below.

IMG_0957

Actual Behavior

On Page load

The thumbnail loads. For a quick second, you can see the desired thumbnail. Then the video player loads. Since the z-index of the video is higher than the thumbnail it gets over written.

When viewing the Media player, on the above operating systems, the first frame of the video seems to be displaying instead of the thumbnail poster. After the video is finished playing, it also doesn't display the thumbnail.

Expected Behavior

When viewing the core video player short code, the thumbnail displays instead of the first frame.

Steps to Reproduce

Setting up

1.) Under CMS configuration enter Media Accounts
2.) Create a New Media Account
3.) Create a Folder
4.) Create a Media Element
5.) On the Media Element create an HTML content block using page zone in SectionA
6.) add the following code to the block, this will give you the GUID of the video{% mediaelement where:'Id == {{ PageParameter.MediaElementId }}' %} {{ mediaelement | Property:'Guid' }} {% endmediaelement %} Copy that GUID for later
7.) On the external Page and block that accepts HTML and add the following code {[ mediaplayer media:'COPIED GUID' thumbnail:'ANY IMAGE' autoresumeindays:'14' combineplaystatisticsindays:'14' width:'100%' ]} {[ endmediaplayer ]}
8.) Save

seeing the bug

  • Go to the page with the block you just created in any of the browsers/devices listed in the above section.
  • Scroll down to the video player.
  • Note that the first frame of the video is displayed instead of the thumbnail video

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

16.2

Client Culture Setting

en-US

@sparkdevnetwork-service sparkdevnetwork-service added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs. labels Feb 14, 2024
@sparkdevnetwork-service sparkdevnetwork-service added the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Feb 28, 2024
@jasonhendee
Copy link
Contributor

@Jchinlcbc, thanks for reporting this issue. Rock v16.4 will include a fix, and our testing shows that video thumbnails are now displayed in MacOS Safari, as well as iOS Safari and Chrome.

In order to provide the best streaming experience possible, Rock uses a 3rd party media player library under the hood. It turns out the issue was within this library's styling of the video and poster (thumbnail) elements. While we don't generally like to patch issues related to external libraries, we felt that this was one we needed to address directly, as the fix is pretty low risk and the issue has been reported but remains unaddressed in that library's repository.

@sparkdevnetwork-service sparkdevnetwork-service removed the Status: In Dev Queue This issue is being worked on, and has someone assigned. label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in v16.4 Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

3 participants