Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsidian List blocks with a grid search field causes default row action on first row of results (Delete) #5860

Open
2 tasks done
bmurphy-dev opened this issue May 6, 2024 · 0 comments
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@bmurphy-dev
Copy link
Contributor

Description

Adding a search and hitting enter on the keyboard during the search causes the grid to take whatever action is on the first row result in the grid. For the aspect of the new Obsidian Batch List block this means deleting an Open or Pending batch which could have a high impact on the Finance teams using Rock.
image

Here's a quick video on this behavior.

This behavior could introduce an accidental loss of data.

Actual Behavior

Using the enter key during grid search causes a "Are you sure you want to delete this Batch?" confirmation alert to appear.

Expected Behavior

Using the enter key within the grid search field should have no impact on the behavior of the results, especially as this action could lead to deleting valuable data.

Steps to Reproduce

  • Go to Finance - Batches
  • Click on Search field
  • Type anything to search and filter the grid and then press your enter key on the keyboard
  • See the Delete dialog pop up for the first batch row in the results grid if it's in Open or Pending status.
    image

I've confirmed this "enter key" in search field behavior exists for any obsidian "list" type of block such as the not yet swapped/chopped Prayer Request List, Adaptive Message List, and the Define Value List blocks.
image
image
image

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

v16.1 through 17.0 (1.17.0.18)

Client Culture Setting

en-US

@sparkdevnetwork-service sparkdevnetwork-service added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs. labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

2 participants