Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The icontype parameter of KPI shortcode doesn't have any effect #5869

Open
2 tasks done
JRichmond27 opened this issue May 10, 2024 · 0 comments
Open
2 tasks done

The icontype parameter of KPI shortcode doesn't have any effect #5869

JRichmond27 opened this issue May 10, 2024 · 0 comments
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.

Comments

@JRichmond27
Copy link

Description

Including a value for the icontype parameter for an item in the kpis shortcode does not seem to have any effect on the resulting HTML output. No matter what, the icon CSS class ends up starting with "fa".

Actual Behavior

Whether the icontype parameter is included or not, the resulting icon CSS class always starts with "fa".

Expected Behavior

If the icontype parameter is omitted, then the icon CSS class should start with "fa".

If the icontype parameter has a value specified, then the resulting icon CSS class should begin with the specified value.

Steps to Reproduce

  1. Add an HTML block to any page
  2. Edit the block and add this Lava to the content area:
{[ kpis ]}
    [[ kpi value:'1234' color:'orange' icontype:'xyz' icon:'icon-class' ]][[ endkpi ]] 
{[ endkpis ]} 
  1. Save the block
  2. Inspect the page's HTML and notice that the icon CSS class for the KPI is fa fa-fw icon-class instead of xyz fa-fw icon-class like it should be

Issue Confirmation

  • Perform a search on the Github Issues to see if your bug or enhancement is already reported.
  • Try to reproduce the problem on a fresh install or on the demo site.

Rock Version

16.3 & 16.5

Client Culture Setting

en-US

@sparkdevnetwork-service sparkdevnetwork-service added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs. labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. Type: Bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Development

No branches or pull requests

2 participants