manually specify tls servername for oob/fbl testing tools #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yepher
reviewed
Apr 12, 2018
| return errors.Wrap(err, "sending MAIL FROM") | ||
| } | ||
|
|
||
| if err := c.Rcpt(to[0]); err != nil { |
There was a problem hiding this comment.
Not a big issue but I would probably lean towards checking array list size and non nil before accessing index 0. It will fail if it is not right but looks like this code is trying to provide helpful details about the root cause of an error.
There was a problem hiding this comment.
Addressed above, thanks!
|
closes #131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.