Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX-745 Add CRA template #1024

Merged
merged 7 commits into from
Dec 21, 2021
Merged

UX-745 Add CRA template #1024

merged 7 commits into from
Dec 21, 2021

Conversation

jonambas
Copy link
Contributor

@jonambas jonambas commented Nov 16, 2021 •
edited
Loading

What Changed

How To Test or Verify

  • Pull down this PR
  • Run npx create-react-app my-app --template file:.path/to/matchbox/packages/matchbox-cra
  • Or run npx create-react-app my-app --template @sparkpost/matchbox

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

@jonambas jonambas closed this Nov 22, 2021
@jonambas jonambas reopened this Dec 10, 2021
logansparlin
logansparlin approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@logansparlin logansparlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'm wondering if we should add a .eslintrc but other than that it's good to go

packages/cra-template-matchbox/template/public/manifest.json Outdated Show resolved Hide resolved
@jonambas jonambas merged commit b594f23 into main Dec 21, 2021
@jonambas jonambas deleted the UX-745 branch December 21, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logansparlin logansparlin logansparlin approved these changes

Assignees
No one assigned
Labels
:shipit: approved type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonambas @logansparlin