Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX-275 Removes datepicker's outside and disabled days click events #532

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

jonambas
Copy link
Contributor

@jonambas jonambas commented Jul 10, 2020

What Changed

  • Adds pointer-events none to disabled days
  • Prevents days from rendering if they are outside

How To Test or Verify

  • Run storybook and visit the datepicker stories
  • Try clicking on days outside the month or disabled days
  • Should not see a console.log

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #532 into main will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #532   +/-   ##
=======================================
  Coverage   93.26%   93.27%           
=======================================
  Files         118      118           
  Lines        1560     1562    +2     
=======================================
+ Hits         1455     1457    +2     
  Misses        105      105           
Impacted Files Coverage Δ
...kages/matchbox/src/components/DatePicker/styles.js 68.75% <ø> (ø)
packages/matchbox/src/components/DatePicker/Day.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdada90...b030fd8. Read the comment docs.

Copy link
Contributor

@logansparlin logansparlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jonambas jonambas merged commit e6ec8b1 into main Jul 13, 2020
@jonambas jonambas deleted the UX-275 branch July 13, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants