Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX-292 Add Button.Icon #576

Merged
merged 2 commits into from
Aug 6, 2020
Merged

UX-292 Add Button.Icon #576

merged 2 commits into from
Aug 6, 2020

Conversation

jonambas
Copy link
Contributor

@jonambas jonambas commented Aug 5, 2020

Closes #522

What Changed

  • Adds new Button.Icon component to handle vertically centering icons easily inside buttons

How To Test or Verify

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

@jonambas jonambas changed the base branch from main to rc/4.1.0 August 5, 2020 13:35
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #576 into rc/4.1.0 will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           rc/4.1.0     #576      +/-   ##
============================================
+ Coverage     93.36%   93.39%   +0.03%     
============================================
  Files           128      129       +1     
  Lines          1688     1696       +8     
============================================
+ Hits           1576     1584       +8     
  Misses          112      112              
Impacted Files Coverage Δ
packages/matchbox/src/components/Button/Button.js 100.00% <100.00%> (ø)
packages/matchbox/src/components/Button/Icon.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d5ce4e...b51d742. Read the comment docs.

Copy link
Contributor

@logansparlin logansparlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jonambas jonambas merged commit a89821c into rc/4.1.0 Aug 6, 2020
@jonambas jonambas deleted the UX-292 branch August 6, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button component should handle passed in icon positioning
2 participants