Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #624 - Add support for data-id for the Panel component #627

Merged
merged 2 commits into from
Sep 10, 2020
Merged

Resolves #624 - Add support for data-id for the Panel component #627

merged 2 commits into from
Sep 10, 2020

Conversation

nicklemmon
Copy link
Contributor

@nicklemmon nicklemmon commented Sep 9, 2020 •
edited by jonambas
Loading

Resoves #624

What Changed

  • Adds support for the data-id prop on the <Panel />

How To Test or Verify

  • Verify via Storybook that data-id is properly rendered to the DOM

PR Checklist

  • Add the correct type label
  • Pull request approval from #uxfe or #design-guild

jonambas
jonambas approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@jonambas jonambas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonambas jonambas merged commit 9f02d9e into main Sep 10, 2020
@jonambas jonambas deleted the resolves-#624 branch February 18, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonambas jonambas jonambas approved these changes

Assignees
No one assigned
Labels
:shipit: approved type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicklemmon @jonambas