Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SparkPostMessage to support campaign #137

Merged
merged 1 commit into from
Feb 1, 2017
Merged

Update SparkPostMessage to support campaign #137

merged 1 commit into from
Feb 1, 2017

Conversation

andyzickler
Copy link
Contributor

Updates sending a Django EmailMessage to support a campaign attribute. Also adds a test to verify.

Closes #136

@richleland richleland merged commit c874555 into SparkPost:master Feb 1, 2017
@richleland
Copy link
Contributor

Thanks for the contribution @andyzickler!

This highlights a design flaw in 1.0 that we're looking to address in 2.0 - passing through params to the API so we don't have to make library updates for something so basic as this. It's also worth noting that in 2.0 we're considering removing the Django backend in favor of django-anymail.

@andyzickler
Copy link
Contributor Author

andyzickler commented Feb 1, 2017

Glad I was able to help out. I did see your comments in #110 but I figured because I had already fixed it locally that I would just go ahead an submit the patch. Thanks for the heads up about django-anymail.

Also that was probably the fastest merging of a pr I've ever seen!

@clhamilton
Copy link

Any chance this PR will be released soon?

@richleland
Copy link
Contributor

@clhamilton @andyzickler yeah we can cut a release tomorrow. I'll update the ticket as soon as it's ready.

@richleland
Copy link
Contributor

1.3.4 is now up on PyPI.

@andyzickler
Copy link
Contributor Author

Thank you so much!

@andyzickler andyzickler deleted the issue-136-django-campaign branch February 16, 2017 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants