Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Templates resource lib #40

Merged
merged 8 commits into from
Aug 25, 2015
Merged

Added Templates resource lib #40

merged 8 commits into from
Aug 25, 2015

Conversation

aydrian
Copy link
Contributor

@aydrian aydrian commented Aug 21, 2015

Closes #14.

@richleland: Please look over this. We can discuss it Monday. I want to make sure I'm doing everything appropriately before continuing on to the other resources.

@richleland
Copy link
Contributor

Awesome work on this - I see a couple minor things and I still want to checkout the branch and test out the resource.

'first_name': 'John',
'last_name': 'Doe'
}
template = sp.transmission.get('template_id', sub_data, True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should create another method here called preview. It can wrap/extend get if need be.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke too soon - looks like the example just needs to get updated! 😸

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, my bad. Copy/Paste error.

@richleland
Copy link
Contributor

I wonder if we should just use draft instead of is_draft - I think the language is just throwing me off - "get this template... it's a draft" vs. "get this template's draft version".

@richleland
Copy link
Contributor

We need to update the sphinx docs to include docs for this resource. I can show you how this works.

@aydrian
Copy link
Contributor Author

aydrian commented Aug 23, 2015

Yeah. Look at the documentation for the whole draft thing.
Let's talk about the sphinx docs on Monday. I thought they were auto generated.

richleland added a commit that referenced this pull request Aug 25, 2015
Added Templates resource lib
@richleland richleland merged commit 4f37988 into SparkPost:master Aug 25, 2015
@aydrian aydrian deleted the ISSUE-14 branch August 25, 2015 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants