-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Templates resource lib #40
Conversation
Awesome work on this - I see a couple minor things and I still want to checkout the branch and test out the resource. |
'first_name': 'John', | ||
'last_name': 'Doe' | ||
} | ||
template = sp.transmission.get('template_id', sub_data, True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should create another method here called preview
. It can wrap/extend get
if need be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spoke too soon - looks like the example just needs to get updated! 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, my bad. Copy/Paste error.
I wonder if we should just use |
We need to update the sphinx docs to include docs for this resource. I can show you how this works. |
Yeah. Look at the documentation for the whole draft thing. |
Added Templates resource lib
Closes #14.
@richleland: Please look over this. We can discuss it Monday. I want to make sure I'm doing everything appropriately before continuing on to the other resources.