More extensibility and Tornado integration #94
Conversation
|
Thanks for contributing @friedcell - the build is failing - can you take a look at the failures and address? https://travis-ci.org/SparkPost/python-sparkpost/builds/118036542 |
| @@ -196,6 +196,11 @@ def send(self, **kwargs): | |||
| results = self.request('POST', self.uri, data=json.dumps(payload)) | |||
| return results | |||
|
|
|||
| def _fetch_get(self, transmission_id): | |||
There was a problem hiding this comment.
Any particular reason this had to be moved out into a separate function?
There was a problem hiding this comment.
To support async transports fetch methods should only return whatever they fetched - in async it will be a future, not a real value that can be manipulated. It enables code in sparkpost/tornado/transmissions.py
|
Hi @friedcell this PR looks pretty solid. I'm not very familiar with Tornado, so adding a few examples would be awesome if you can squeeze that in. It would also be great to get a section covering Tornado usage in the Sphinx docs. |
Updated the code to make it more extensible (easier subclassing, allows async transports) and then added support for tornado and its transport via AsyncHTTPClient