Handle API errors in SparkPostAPIException #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah cool there is some overlap here with an open PR - check out https://github.com/SparkPost/python-sparkpost/pull/94/files#diff-bf66564894a4a13c92ffe4ebed2d79d8L5 - mind commenting and discussing with @friedcell about it over on that PR? |
|
Merged in #94, which contains similar additions to the exception class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the API returns 5xx errors, the response typically does not actually include any json, which causes JSONDecodeErrors to be raised by
response.json(). This branch addresses that issue by only parsing the response as json if the content-type response header is set correctly.Additionally, it sets
response_status_codeandresponse_errors_codeson the SparkPostAPIException so that applications can catch the exception and react accordingly. 5xx errors should usually be retried, while 4xx errors sometimes should be retried (rate limit) and other times be fatal (recipient on suppression list).