Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE-1168: SparkPost logo is broken on Wordpress plugin admin page #157

Merged
merged 7 commits into from
Sep 2, 2020

Conversation

bkemper
Copy link
Contributor

@bkemper bkemper commented Sep 1, 2020

This was a customer reported issue. See screenshot.

logo

To verify this fix worked correctly:

  1. We will need to deploy a new version v3.2.3 of the plugin
  2. Then confirm all files in assets/ arrive in https://plugins.trac.wordpress.org/browser/sparkpost/assets

deploy.sh Show resolved Hide resolved
@bkemper bkemper force-pushed the FE-1168 branch 3 times, most recently from 23c618c to 8dfaa84 Compare September 2, 2020 14:45
@chieftechdog
Copy link

Hi @bkemper @maxharrisnet ,

It doesn't look like the issue was actually resolved in 3.2.3. I'm still seeing the broken logo on the plugin Settings page.

The "assets" folder is still missing from the package on WordPress.org repo.

Could you please double-check again? Thanks!

@bkemper
Copy link
Contributor Author

bkemper commented Sep 4, 2020

@chieftechdog Thanks! I'll take another look next week.

maxharrisnet pushed a commit that referenced this pull request Sep 17, 2020
AC-1583 Set the sitemap in robots.txt
@chieftechdog
Copy link

chieftechdog commented Oct 1, 2020

Hi @bkemper and @maxharrisnet ,

Following up on this issue. It still does not seem to be resolved in the latest version of the plugin available on WordPress.org repo.

Could you please check on this when you have a chance? Thanks so much!

@chieftechdog
Copy link

@bkemper @maxharrisnet Following up again. I understand it's not a major issue, but I think it just looks bad that there are missing assets. It should be a quick fix hopefully. Thanks!

@chieftechdog
Copy link

@bkemper @maxharrisnet Hey guys, following up on this old issue. Plugin hasn't been updated in a while, but if there's any plan to release a new version of the plugin, hopefully this issue can be fixed as well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants