Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch OpenWeatherMap API URLs to HTTPS #28

Closed
wants to merge 2 commits into from
Closed

Switch OpenWeatherMap API URLs to HTTPS #28

wants to merge 2 commits into from

Conversation

SkewedZeppelin
Copy link

@Sparker0i
Copy link
Owner

Hey there,

Since the last few builds, travis has been giving me error in building. I'm not able to verify what the error is, so meanwhile can you post the screenshot of the app working on your phone (with this commit), and also attach the debug apk?

@SkewedZeppelin
Copy link
Author

SkewedZeppelin commented Nov 3, 2017

@Sparker0i I've not actually compiled this as I've made this commit to multiple weather apps, but I can confirm that HTTPS API access does indeed work.

And I've added a commit to Fix your Travis builds :)

@Sparker0i
Copy link
Owner

The build has failed. I cannot accept this ATM. Do consider sending another PR without Travis part

@Sparker0i Sparker0i closed this Nov 3, 2017
@SkewedZeppelin
Copy link
Author

SkewedZeppelin commented Nov 3, 2017

That Travis commit does fix one issue, it seems there is another issue however. I've removed it.

Edit: Even though I removed it, GitHub hasn't seemed to update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants