Move towards C++ type/node interfaces and add unit-testing to Feather #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly name Nest structures with Nest_prefix (remove the typedefs that don’t include this prefix). Add C++ wrappers for some commonly used Nest types: - NodeHandle - NodeRange - StringRef
Also adding unittests for these types
Also fix the operator<< location from Diagnostic.hpp; it need to be outside of the Nest namespace, it order to be properly picked up.
All feather nodes are not fully contained in their corresponding classes
So far we mostly test expression
(also rename TypeBase into Type)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.