Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : 메인페이지 구현 #25

Merged
merged 24 commits into from
May 7, 2024
Merged

feat : 메인페이지 구현 #25

merged 24 commits into from
May 7, 2024

Conversation

yeeunseo-dev
Copy link
Collaborator

@yeeunseo-dev yeeunseo-dev commented May 6, 2024

close #16

  • 스와이퍼를 사용해 wavve 메인 클론코딩 구현했습니다.

  • main 캐러셀 이미지가 작아서 퀄리티가 좋진 않지만 기능 위주로 봐주세요.

  • main 캐러셀에 타이틀� 넣으면 좋을 것 같은데, 의견 부탁드려요

  • swiper 사용했습니다

@yeeunseo-dev yeeunseo-dev added the enhancement New feature or request label May 6, 2024
@yeeunseo-dev yeeunseo-dev self-assigned this May 6, 2024
@yeeunseo-dev yeeunseo-dev changed the title Feature/create main feat : 메인페이지 구현 May 6, 2024
@Ahnjonghyun87
Copy link
Collaborator

l g t m

Copy link
Member

@1eeyerin 1eeyerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js 코드를 엄청 깔끔하게 작성하셨네요! 보기 수월했습니다!
코멘트가 많지만.. 잘 부탁드립니다! 😂 코멘트중 궁금한 것이 있다면 말씀주세요!

css/index.css Outdated Show resolved Hide resolved
css/index.css Outdated Show resolved Hide resolved
css/index.css Outdated Show resolved Hide resolved
css/index.css Outdated Show resolved Hide resolved
css/index.css Outdated Show resolved Hide resolved
js/index.js Outdated Show resolved Hide resolved
js/index.js Outdated Show resolved Hide resolved
js/index.js Show resolved Hide resolved
js/index.js Outdated Show resolved Hide resolved
js/index.js Outdated Show resolved Hide resolved
js/index.js Outdated Show resolved Hide resolved
Copy link
Member

@1eeyerin 1eeyerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다 예은님~ lgtm!
이미지만 고화질로 변경 부탁드릴게요!

css/index.css Outdated Show resolved Hide resolved
css/index.css Outdated Show resolved Hide resolved
Copy link
Collaborator

@Ahnjonghyun87 Ahnjonghyun87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l g t m

@yeeunseo-dev yeeunseo-dev merged commit af70590 into develop May 7, 2024
@yeeunseo-dev yeeunseo-dev deleted the feature/create-main branch May 7, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

메인페이지 구현
4 participants