Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature language value in specflow.json is ignored by Visual Studio extension #1291

Closed
david1995 opened this issue Oct 2, 2018 · 2 comments
Closed

Feature language value in specflow.json is ignored by Visual Studio extension #1291

david1995 opened this issue Oct 2, 2018 · 2 comments
Labels
Bug .NET Core Support SpecFlow Team Backlog this issue are in the backlog of the SpecFlow Team VisualStudioIntegration
Projects
.NET Core Support
Milestone
SpecFlow 3.0

Comments

@david1995
Copy link
Contributor

When specifying a different feature language than the default one (which is en-us) in a specflow.json configuration, syntax highlighting and IntelliSense for Gherkin files doesn't work for the specified language in Visual Studio. Instead, it uses the previously mentioned default value. Probably the value is ignored by the Visual Studio extension. Though, building succeeds when using the MSBuild integration instead of SpecFlowSingleFileGenerator.

Since support for specflow.json is only integrated in the DotNetCore branch in the Visual Studio extension, the issue occurs exclusively when the preview version is used.
@david1995 david1995 added Bug VisualStudioIntegration .NET Core Support SpecFlow Team Backlog this issue are in the backlog of the SpecFlow Team labels Oct 2, 2018
@SabotageAndi SabotageAndi added this to Todo in .NET Core Support via automation Oct 3, 2018
@SabotageAndi SabotageAndi added this to the SpecFlow 3.0 milestone Oct 3, 2018
@david1995
Copy link
Contributor Author

I tried to reproduce the issue today. The bug only occurs when I change the specflow.json and e.g. write a feature file in another language. Thus, I think there is an issue with reloading the configuration once it is changed.

@david1995 david1995 moved this from Todo to In Progess in .NET Core Support Oct 4, 2018
@david1995 david1995 mentioned this issue Oct 4, 2018
Merged
SabotageAndi pushed a commit to SpecFlowOSS/SpecFlow.VisualStudio that referenced this issue Oct 8, 2018
@david1995 @SabotageAndi
Fix specflow.json not being reloaded after editing (#36)
e25f696 
Resolves SpecFlowOSS/SpecFlow#1291
.NET Core Support automation moved this from In Progess to Done Oct 8, 2018
littlegenius666 pushed a commit to littlegenius666/SpecFlow.VisualStudio that referenced this issue May 3, 2019
@david1995 @SabotageAndi
Fix specflow.json not being reloaded after editing (SpecFlowOSS#36)
f352dd2 
Resolves SpecFlowOSS/SpecFlow#1291
@lock
Copy link

lock bot commented Jul 8, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug .NET Core Support SpecFlow Team Backlog this issue are in the backlog of the SpecFlow Team VisualStudioIntegration
Projects
No open projects
.NET Core Support
  
Done
Milestone
SpecFlow 3.0
Development

No branches or pull requests
2 participants
@SabotageAndi @david1995