Order sensitive comparison should display missing rows if there are more expected rows in the table than were returned #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Results are present but there should be no results" is a subcondition of "extra results exist".
19 tasks
|
@midgleyc thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if there are fewer returned results than the table has rows, using order insensitive comparison displays the absent rows, but order sensitive comparison does not. This adds a test for the latter case and fixes the implementation.
I also cleaned up the implementation slightly, hopefully without changing the behaviour: it now calculates missing items once, instead of three times, and no longer considers "there are results but should be none" separately to "there are more results than expected", as the former is a subcase of the latter.