Allow to convert type to same type or one of base types with StepArgumentTransformation #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChernyavskiyAlex
changed the title
|
@gasparnagy This is your PR to review. |
gasparnagy
requested changes
Apr 17, 2018
|
|
||
| var stepTransformation = GetMatchingStepTransformation(value, typeToConvertTo, false); | ||
| if (stepTransformation != null) | ||
| return true; | ||
|
|
||
| var convertToType = Type.GetType(typeToConvertTo.FullName); |
| var stepTransformation = GetMatchingStepTransformation(value, typeToConvertTo, true); | ||
| if (stepTransformation != null) | ||
| return DoTransform(stepTransformation, value, cultureInfo); | ||
|
|
||
| var convertToType = Type.GetType(typeToConvertTo.FullName); |
There was a problem hiding this comment.
Instead of using Type.GetType, please try to safely cast typeToConvertTo into RuntimeBindingType and if the cast is valid, get the runtime type from there.
(Type.GetType only works reliably if you pass an assembly-qualified type name to it.)
|
Thanks, code by your remarks was added |
|
@ChernyavskiyAlex one small request from me: could you add an entry into the changelog? Thanks! |
|
done |
|
@gasparnagy are you agree with changes i made? |
|
@ChernyavskiyAlex Thx! |
alexvv
pushed a commit
to alexvv/SpecFlow
that referenced
this pull request
Apr 29, 2018
…mentTransformation (SpecFlowOSS#1110) * Type to same or derived type conversion added * Tests added * Tests fixing * Fixed by gasparnagy remartks * Changelog updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the key needs is to create keywords as "example" or "table" value and resolve it in runtime.
As example:
Suppose wit ha some scenario outline with example block like that:
Examples:
|date|
|#{uniq_id}|
and binding:
[StepArgumentTransformation]
public string KeywordTransformation(string value){
if (value == #{uniq_id})
return Guid.NewGuid.ToString();
}
as a result in test we get the transformed value.