New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve value retriever/comparer registration #1260
Merged
SabotageAndi
merged 18 commits into
SpecFlowOSS:master
from
szaliszali:1218-improved-retriever-registration
Sep 20, 2018
Merged
Improve value retriever/comparer registration #1260
SabotageAndi
merged 18 commits into
SpecFlowOSS:master
from
szaliszali:1218-improved-retriever-registration
Sep 20, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea with the ServiceComponentList
class, so I think I prefer this PR over #1267.
@szaliszali Could you add an entry in the changelog for this.
szaliszali
force-pushed
the
1218-improved-retriever-registration
branch
from
September 19, 2018 11:25
9e8025d
to
11a68f2
Compare
szaliszali
force-pushed
the
1218-improved-retriever-registration
branch
from
September 19, 2018 18:01
f53ffbd
to
65bd6ec
Compare
rebased the branch on current master and force pushed to solve merge conflict without the mess |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1218
I think there is too much similarity in comparer and retriever handling in the Assist service, so I propose they could be merged into one with a small API change:
Before:
After:
Additions:
Pros:
Cons:
Types of changes
Checklist: