Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimePlugin Locator looks into TestAssembly folder #1597

Conversation

SabotageAndi
Copy link
Contributor

as on .NET Core the SpecFlow.dll is not in the output folder and current directory is set to the TestResults folder, we have to search for runtime plugins in the test assembly folder

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added an entry to the changelog

…ent directory is set to the TestResults folder, we have to search for runtime plugins in the test assembly folder
@SabotageAndi SabotageAndi merged commit f408485 into SpecFlowOSS:master Jun 4, 2019
@gasparnagy
Copy link
Contributor

@SabotageAndi Oh... you seem to have changed a core interface IContainerBuilder in a patch release... Breaks my stuffs... :(

@SabotageAndi
Copy link
Contributor Author

@gasparnagy Why are you calling such internal class?

@gasparnagy
Copy link
Contributor

It is the starting point to create ITestRunner (if you want to tweek some deps), I thought SpecRun also uses it. Never mind, I have solved it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants