Empty root namespace #1606
Merged
Empty root namespace #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove [Required] from build task RootNamespace * Take folder paths into account when root namespace absent * Add tests for previously supported and new scenarois
|
Thanks for your contribution to SpecFlow. If you would like us to send you some SpecFlow stickers as a thank you, please fill out the form here. |
idg10
added a commit
to idg10/SpecFlow
that referenced
this pull request
Jan 8, 2020
* Enable empty root namespace * Remove [Required] from build task RootNamespace * Take folder paths into account when root namespace absent * Add tests for previously supported and new scenarois * Add changelog entry for root namespace fix
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1605
It also makes the behaviour in empty-root-namespace scenarios more consistent with when the root namespace is specified. Back when empty root namespaces worked (which they did if you used the custom tool to generate codebehind) the folder path to the class wasn't taken into account like it is in non-empty cases. You just ended up with the same default namespace for everything. With this change, files in subfolders go in namespaces based on that file structure, exactly like they do when the root namespace is non-empty, and exactly as happens when you ask VS to add a new file to a subfolder (whether or not the root namespace is empty).
Types of changes
Checklist: