Fix1544 - Change search path for specflow.json and update configuration tests #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! |
…lie result instead of output result
|
Thank you, I have added an entry to the changelog |
|
Thanks for your contribution to SpecFlow. If you would like us to send you some SpecFlow stickers as a thank you, please fill out the form here. |
This was referenced Jul 2, 2019
idg10
pushed a commit
to idg10/SpecFlow
that referenced
this pull request
Jan 8, 2020
…on tests (SpecFlowOSS#1629) * enable configuration scenarios * Change search path for specflow.json * Change test condition to look for configuration usage strings in complie result instead of output result * Fix configuration tests * Update submodule version * Fix assertion * enable configuration scenarios * Change search path for specflow.json * Change test condition to look for configuration usage strings in complie result instead of output result * Fix configuration tests * Update submodule version * Fix assertion * Update changelog.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetSpecflowJsonFilePath method was looking for the specflow.json file in Environment.CurrentDirectory which may not be set to the same paths for all test frameworks. This was changed to AppDomain.CurrentDomain.BaseDirectory (the same directory as the project file).
I have also changed the assertions for the configuration tests to look for strings such as "Using specflow.json" in the compile results output instead of the test results output.
Types of changes
Checklist: