Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct props file path case #1637

Merged
merged 1 commit into from Jun 28, 2019
Merged

Correct props file path case #1637

merged 1 commit into from Jun 28, 2019

Conversation

MikeVerius
Copy link
Contributor

SpecFlow.Tools.MsBuild.Generation.props used a different casing to reference the Buildsystem folder than is present in the package. This seems like the smallest change to correct an out of the box failure utilising the MsBuild generation on linux. Is nobody using SpecFlow on linux or macOS at the moment? Anyway this fix isn't a code change and the casing of a path should have no effect on Windows users.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added an entry to the changelog

SpecFlow.Tools.MsBuild.Generation.props used a different casing to reference the Buildsystem folder than is present in the package. This seems like the smallest change to correct an out of the box failure utilising the MsBuild generation on linux.
@SabotageAndi SabotageAndi merged commit ba116a1 into SpecFlowOSS:master Jun 28, 2019
@SabotageAndi
Copy link
Contributor

Thanks for your contribution to SpecFlow. If you would like us to send you some SpecFlow stickers as a thank you, please fill out the form here.

idg10 pushed a commit to idg10/SpecFlow that referenced this pull request Jan 8, 2020
SpecFlow.Tools.MsBuild.Generation.props used a different casing to reference the Buildsystem folder than is present in the package. This seems like the smallest change to correct an out of the box failure utilising the MsBuild generation on linux.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants