Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enum retriever for nullable enums and empty value #1941

Merged
merged 4 commits into from
May 7, 2020
Merged

Fix enum retriever for nullable enums and empty value #1941

merged 4 commits into from
May 7, 2020

Conversation

304NotModified
Copy link
Contributor

@304NotModified 304NotModified commented Apr 10, 2020 •
edited

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code. (most of the time mandatory)
  • I have added an entry to the changelog. (mandatory)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

supersedes #822
fixes #404

@SabotageAndi thanks for the tests! :)

@304NotModified 304NotModified marked this pull request as ready for review April 10, 2020 15:33
@304NotModified 304NotModified changed the title Fix enum retriever Fix enum retriever for nullable enums Apr 10, 2020
@304NotModified
Copy link
Contributor Author

304NotModified commented Apr 10, 2020 •
edited

🤞 hope it all builds and works, I have trouble getting the build running local...

Error MSB3027 Could not copy "E:\vs\SpecFlow\TechTalk.SpecFlow.Generator\bin\Debug\net471\TechTalk.SpecFlow.Generator.dll" to "bin\Debug\net471\TechTalk.SpecFlow.Generator.dll". Exceeded retry count of 10. Failed. The file is locked by: "MSBuild.exe (106232), MSBuild.exe (102436)" SpecFlow.Tools.MsBuild.Generation C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets 4377

update: all green now locally:

image

@304NotModified 304NotModified changed the title Fix enum retriever for nullable enums Fix enum retriever for nullable enums and empty value Apr 10, 2020
@304NotModified 304NotModified mentioned this pull request Apr 10, 2020
Closed
@304NotModified
Copy link
Contributor Author

Only this test fails:

Before/After TestRun hook should only be executed once: AfterTestRun [FAIL]

Flaky and unrelated to this change?

@304NotModified
Copy link
Contributor Author

close/reopen to trigger CI (flaky test?)

@304NotModified
Copy link
Contributor Author

force push to retrigger al builds

@SabotageAndi
Copy link
Contributor

Thanks for this fix. Sorry that it took so long for me to review.
Could you rebase the PR on master and adjust the changelog?

@SabotageAndi SabotageAndi self-assigned this May 5, 2020
SabotageAndi
SabotageAndi suggested changes May 5, 2020
View reviewed changes
Copy link
Contributor

@SabotageAndi SabotageAndi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix. Sorry that it took so long for me to review.
Could you rebase the PR on master and adjust the changelog?

@304NotModified
Copy link
Contributor Author

@SabotageAndi rebase done!

@304NotModified
Copy link
Contributor Author

I think flaky tests

image

@SabotageAndi
Copy link
Contributor

I don't think they are flaky. That's the first time I saw this 2 tests are failing. And I configured Rerun failed tests in the meantime on the pipeline and all retries failed also.

@304NotModified
Copy link
Contributor Author

Well with a rebase they suddenly stopped running, will restart and i'm 90% sure there are flaky.

@304NotModified 304NotModified reopened this May 6, 2020
@304NotModified 304NotModified marked this pull request as draft May 6, 2020 14:46
@304NotModified 304NotModified marked this pull request as draft May 6, 2020 14:46
@304NotModified
Copy link
Contributor Author

Will check the failed tests

@304NotModified 304NotModified marked this pull request as ready for review May 6, 2020 20:04
@304NotModified
Copy link
Contributor Author

@SabotageAndi could you please restart the failed run?

I haven't changed anything, now previous failed tests are green but others have failed.

@SabotageAndi SabotageAndi merged commit 2602a90 into SpecFlowOSS:master May 7, 2020
@bollhals bollhals mentioned this pull request May 8, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SabotageAndi SabotageAndi SabotageAndi requested changes

Assignees

@SabotageAndi SabotageAndi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nullable enums can't handle null value: No enum with value found
2 participants
@304NotModified @SabotageAndi